Promote arguments of norminvcdf and norminvccdf
#132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #132 +/- ##
==========================================
+ Coverage 38.73% 39.30% +0.56%
==========================================
Files 13 13
Lines 426 430 +4
==========================================
+ Hits 165 169 +4
Misses 261 261
Continue to review full report at Codecov.
|
sethaxen
reviewed
Jan 22, 2022
devmotion
commented
Jan 22, 2022
Co-authored-by: Seth Axen <seth.axen@gmail.com>
nalimilan
approved these changes
Jan 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently these functions compute
erfcinvin possibly lower precision and only take into account the parameters (and their types) of the normal distribution afterwards. This PR fixes and tests this problem.