Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix quantiles of degenerate beta distributions #158

Merged
merged 2 commits into from
Feb 24, 2023
Merged

Conversation

devmotion
Copy link
Member

Fix #154 by handling degenerate beta distributions in quantile functions.

To make it clearer and more consistent I also added cases for the degenerate beta distribution with zero beta parameter to the other functions; currently we rely on how SpecialFunctions handles these degenerate cases.

@codecov-commenter
Copy link

codecov-commenter commented Feb 1, 2023

Codecov Report

Base: 61.58% // Head: 62.79% // Increases project coverage by +1.20% 🎉

Coverage data is based on head (86d60fc) compared to base (7782629).
Patch coverage: 100.00% of modified lines in pull request are covered.

❗ Current head 86d60fc differs from pull request most recent head e22f78a. Consider uploading reports for the commit e22f78a to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #158      +/-   ##
==========================================
+ Coverage   61.58%   62.79%   +1.20%     
==========================================
  Files          14       14              
  Lines         617      637      +20     
==========================================
+ Hits          380      400      +20     
  Misses        237      237              
Impacted Files Coverage Δ
src/distrs/beta.jl 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@devmotion devmotion merged commit 87a760a into master Feb 24, 2023
@devmotion devmotion deleted the dw/beta_degenerate branch February 24, 2023 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tdistinvcdf(0, 0.975) hangs
3 participants