-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add logsubexp(x,y) #95
Conversation
Merge? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have the feeling we discussed similar xlogx
issues recently but I can't find where...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
@nalimilan Thank you for taking a look! |
After considering this again, I found out that |
Good point @nalimilan. Done. |
Please tag a release with this. Thanks! |
This is useful in some contexts. Other libraries have this, for example, https://www.tensorflow.org/probability/api_docs/python/tfp/math/log_sub_exp
If this gets merged please tag a release (I bumped the version here).