Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

needs update for string.data changes #11

Closed
stevengj opened this issue Jan 4, 2017 · 2 comments
Closed

needs update for string.data changes #11

stevengj opened this issue Jan 4, 2017 · 2 comments

Comments

@stevengj
Copy link
Member

stevengj commented Jan 4, 2017

After JuliaLang/julia#19449, soon to be merged for Julia 0.6, you will no longer be able to access the raw bytes of a string via string.data; instead, do Vector{UInt8}(string). For example, this affects:

https://github.com/JuliaArchive/LegacyStrings.jl/blob/d96e96adadd7cec0ddfe2342d1929a5a972247a2/src/ascii.jl#L100
@matthias314
Copy link
Contributor

At least the example is already fixed by #29.

@stevengj
Copy link
Member Author

Yes, this issue can be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@stevengj @matthias314