Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix errors on julia 0.7, drop 0.5 support #29

Merged
merged 1 commit into from
Jul 24, 2018
Merged

Fix errors on julia 0.7, drop 0.5 support #29

merged 1 commit into from
Jul 24, 2018

Conversation

carlobaldassi
Copy link
Contributor

All tests pass (locally) without deprecation warnings on both julia 0.6 and 0.7 (some warnings still remain, e.g. the one about exporting ascii).

This supersedes #21. I've seen that in that PR there was some debate on whether to abandon the package, but it is required in particular by JLD, so I've put in the work to fix it. Hopefully, no more major fixes will be required after 1.0.

all tests pass without deprecation warnings;
some deprecation warnings still remain though
@carlobaldassi
Copy link
Contributor Author

@stevengj thanks for reviewing. If there are no objections/comments from others this may be merged then? (I don't have write access in this repo.)

@ararslan
Copy link
Member

This seems fine to me, but I kind of assumed that use of this package would have died out by the time people started using Julia 0.7. (I actually thought this repo was in JuliaArchive but I guess it got moved for some reason?)

@carlobaldassi
Copy link
Contributor Author

It's used by JLD, which aims to support archives from older julia versions too.

@ararslan
Copy link
Member

I also hoped people would move from JLD to JLD2. 😄

@carlobaldassi
Copy link
Contributor Author

Sure. But what if I have an old archive written by JLD? (I certainly have a few of those around...)
Also, the JLD2 readme still has this disclaimer: "If your tolerance for data loss is low, JLD may be a better choice at this time."
Anyway, I don't see any reason not to fix the package once the work to fix it is done, right?

@ararslan
Copy link
Member

No, like I said this seems fine to me, I was just surprised someone cared about fixing it. I'd merge this but I don't have commit access in JuliaStrings (though I could have merged it before the repo was moved from JuliaArchive).

@stevengj stevengj merged commit 5cb3d2c into JuliaStrings:master Jul 24, 2018
@carlobaldassi carlobaldassi deleted the fix07 branch July 24, 2018 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants