Fix most issues on julia 0.7 (a few still remain) #215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tests pass on both 0.6 and 0.7; some tests however are disabled since they are still failing.
They are no longer singletons in Julia 0.7. Re-enable related tests. Also improve annotations for some other issues.
triggered by JLDArchives tests
|
Update: after testing with JLDArchives as well, I fixed a few additional problems, and found a couple of new issues when reading from old archives due to changes in the internal representations of |
This was referenced Jul 26, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes most of the issues on julia 0.7, provided that this PR for LegacyStrings is used. Also, this PR for HDF5 is needed to avoid a few additional warnings, as well as the master version of FileIO (which is about to be tagged perhaps).
With all that, tests pass without errors. However, I had to disable a few of them and couldn't figure out how to fix them. The details are below. At least this is considerable progress, I think. Maybe if the code here looks good it can be merged and the remaining issues could be fixed subsequently by someone more skilled. This PR supersedes (actually includes) #214.
Now for the remaining issues. There are 3 of them. They are all marked by "FIXME" comments in the test files.
There is a problem with reading out data with mmap, due to possible misalignments. This is a consequence of Fix and enforce reinterpret/unsafe_wrap alignment JuliaLang/julia#21831. A minimal script that reproduces the issue 100% of the times on my laptop is here. The error comes from
unsafe_wrapcomplaining that the data is not 8-bytes aligned.There is also a problem with an immutable type with a
Union{Int64,Float64}field. In this case, when Julia tries to read back the object, it gives a LoadError with the message "reference encountered in pointerfree immutable; this is a bug". Minimal script to reproduce the issue here.I had to disable the DataFrames tests entirely: it segfaults when reading back the DataFrame. I don't know whether this is an issue in JLD or DataFrames.