fix various depwarns under 0.7 #21
Conversation
| @@ -49,15 +49,15 @@ using Compat | |||
| end | |||
|
|
|||
| if VERSION >= v"0.5.0-" | |||
| immutable ASCIIString <: DirectIndexString | |||
| struct ASCIIString <: DirectIndexString | |||
There was a problem hiding this comment.
This package still supports 0.4 but struct only parses properly on 0.6+.
There was a problem hiding this comment.
Good catch! I should change the version requirements as well.
There was a problem hiding this comment.
Bumped REQUIRE and CI to Julia 0.6+. Thanks!
There was a problem hiding this comment.
Presumably this package will be mostly unnecessary as packages move away from 0.4 support, so bumping the requirement to 0.6 might not be worth it at this point. Probably no harm in doing so though. Seems like a good question for @tkelman.
There was a problem hiding this comment.
Does tagging a release prior to this pull request and then carrying on do the trick? Or does that approach present pitfalls?
There was a problem hiding this comment.
+1 for simply making this package unnecessary
There was a problem hiding this comment.
That sounds like the best approach insofar as possible! :)
There was a problem hiding this comment.
(Looks like JLDArchives, StringEncodings, JLD, SALSA, and SQLite depend on this package.)
There was a problem hiding this comment.
SALSA.jl uses UTF32String for some reason, I can't see why, since it is not for interop.
SQLite.jl uses UTF16String for calling external C interfaces, but it looks like it could use Base.transcode instead.
There was a problem hiding this comment.
StringEncodings uses LegacyStrings mainly as a way exercize support for string types in different encodings. I could easily remove it if LegacyStrings is declared obsolete.
OTOH, if that's not too much work keeping the package alive makes sense, as these string types can be useful for specialized use cases. Of course somebody could revive it if it's really needed.
|
This was superseded by #29 and can be closed. |
See title. Best! :)