Remove string(::Union{ByteString,Char}...) method #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Any objections here? Otherwise, I'd like to see this merged so that progress can continue on JuliaLang/julia#21965 and JuliaLang/julia#21892. |
|
I did this simple benchmark: @benchmark string('a', $(ASCIIString("benchmark"^100)))Run-time was increased from ~185ns to ~740ns. Are there any uses of LegacyStrings out there which are performance critical? Then we could consider adding string(a::Char...) = invoke(string, Tuple{Vararg{Union{Char,String}}}, a...)instead of removing the offending method, but that is a bit fragile with respect to changes in Base. Opinions? |
|
We shouldn't use invoke. I doubt it is worth optimizing this |
|
So... Merge as is? |
|
Thanks. Can we get a new version tagged, too? |
|
Tagged v0.2.2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given how long #8 has been dormant, I propose this simple fix. For
string(::ByteString...), the dedicated method above the deleted one is used. Forstring(::Char...)the method fromBaseis used (that previously was the cause of the ambiguity). For a mixture ofByteStringandChararguments, thestring(::Any...)fallback is used, which should give the correct result, but might be a bit slower (though I haven't checked this).