Add RevString from Base #22
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nalimilan
reviewed
Sep 7, 2017
| s = convert(String, string(prefix, c, suffix)) | ||
| s = RevString(s) | ||
| r = reverse(s) | ||
| ri = search(r, c) |
Member
There was a problem hiding this comment.
Should also check that @test r == RevString(s) (and not overwrite s with the reversed string).
Member
Author
There was a problem hiding this comment.
I hadn't really noticed how weird this code is...
Member
Author
There was a problem hiding this comment.
r isn't the same as RevString(s), since s was redefined as the RevString of itself, so reverse(s) should then be the original s from before it was RevString'd.
Member
There was a problem hiding this comment.
Yes but since the original s is lost, you can't check that the result is correct...
Member
Author
There was a problem hiding this comment.
These tests should be pretty much entirely rewritten.
ararslan
force-pushed
the
aa/revstring
branch
from
2820e80 to
36d8564
Compare
Member
Author
|
Nightly failure is unrelated. |
StefanKarpinski
approved these changes
Dec 5, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of JuliaLang/julia#22611