Skip to content

Conversation

stevengj
Copy link
Member

Closes #29, cc @adienes

@adienes
Copy link

adienes commented Aug 1, 2025

seems right to me, although I suppose there are some in-progress plans to simplify the migration path that may be even simpler?

@stevengj
Copy link
Member Author

stevengj commented Aug 1, 2025

I want to have exactly the same hash as String if possible, so I copied the new hash(::String) implementation.

If we get a generic version that gives the same hash and is almost as fast, I can always delete this method. (But the sad fact is that StringViews.jl requires a lot of access to Julia internals, e.g. for regex searching.)

Copy link

codecov bot commented Aug 1, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 77.58%. Comparing base (7c7f0b6) to head (be1826d).
⚠️ Report is 30 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #30      +/-   ##
==========================================
+ Coverage   75.05%   77.58%   +2.52%     
==========================================
  Files           6        6              
  Lines         417      473      +56     
==========================================
+ Hits          313      367      +54     
- Misses        104      106       +2     
Flag Coverage Δ
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@stevengj stevengj merged commit d56f4b6 into main Aug 1, 2025
15 checks passed
@stevengj stevengj deleted the stevengj-patch-1 branch August 1, 2025 01:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

memhash is to be deleted in 1.13
2 participants