fix: more test/bug fixes

[AayushSabharwal]

No description provided.

[github-actions]

Benchmark Results (Julia v1)

Time benchmarks

	master	2c8f1b8...	master / 2c8f1b8...
arithmetic/addition	0.0711 ± 0.0023 ms	0.0695 ± 0.00077 ms	1.02 ± 0.035
arithmetic/division	10.6 ± 0.53 μs	0.0357 ± 0.00065 ms	0.297 ± 0.016
arithmetic/multiplication	0.449 ± 0.014 ms	0.0479 ± 0.0013 ms	9.38 ± 0.39
overhead/acrule/a+2	5.75 ± 0.14 μs	2.16 ± 0.06 μs	2.66 ± 0.098
overhead/acrule/a+2+b	0.09 ± 0.01 μs	0.07 ± 0.01 μs	1.29 ± 0.23
overhead/acrule/a+b	9.45 ± 0.17 μs	3.75 ± 0.11 μs	2.52 ± 0.087
overhead/acrule/noop:Int	30 ± 0 ns	30 ± 0 ns	1 ± 0
overhead/acrule/noop:Sym	0.05 ± 0.01 μs	0.051 ± 0.01 μs	0.98 ± 0.27
overhead/get_degrees/large_poly	0.159 ± 0.011 s	0.112 ± 0.0054 s	1.42 ± 0.12
overhead/rule/noop:Int	0.06 ± 0.001 μs	0.06 ± 0 μs	1 ± 0.017
overhead/rule/noop:Sym	0.061 ± 0.01 μs	0.06 ± 0.01 μs	1.02 ± 0.24
overhead/rule/noop:Term	0.06 ± 0.01 μs	0.06 ± 0.001 μs	1 ± 0.17
overhead/ruleset/noop:Int	0.16 ± 0.01 μs	30 ± 0 ns	5.33 ± 0.33
overhead/ruleset/noop:Sym	0.17 ± 0.001 μs	0.13 ± 0.01 μs	1.31 ± 0.1
overhead/ruleset/noop:Term	4.48 ± 0.25 μs	0.892 ± 0.02 μs	5.02 ± 0.3
overhead/simplify/noop:Int	0.271 ± 0.011 μs	30 ± 0 ns	9.03 ± 0.37
overhead/simplify/noop:Sym	0.271 ± 0.011 μs	0.04 ± 0.01 μs	6.78 ± 1.7
overhead/simplify/noop:Term	0.091 ± 0.011 ms	27.2 ± 0.53 μs	3.34 ± 0.41
overhead/simplify/randterm (+, *):serial	0.915 ± 0.054 s	0.26 ± 0.025 s	3.52 ± 0.4
overhead/simplify/randterm (+, *):thread	1.64 ± 0.33 s	0.261 ± 0.021 s	6.29 ± 1.4
overhead/simplify/randterm (/, *):serial	0.295 ± 0.023 ms	0.0874 ± 0.011 ms	3.37 ± 0.49
overhead/simplify/randterm (/, *):thread	0.332 ± 0.027 ms	0.0913 ± 0.013 ms	3.64 ± 0.6
overhead/substitute/a	0.0938 ± 0.011 ms	0.0553 ± 0.003 ms	1.7 ± 0.22
overhead/substitute/a,b	0.0853 ± 0.0096 ms	0.0738 ± 0.0041 ms	1.16 ± 0.15
overhead/substitute/a,b,c	0.0666 ± 0.0038 ms	0.0765 ± 0.0051 ms	0.87 ± 0.077
polyform/easy_iszero	0.0385 ± 0.0019 ms	24.3 ± 0.44 μs	1.58 ± 0.084
polyform/isone	3.38 ± 0.067 ms	0.989 ± 0.018 ms	3.42 ± 0.092
polyform/isone:noop	30 ± 0 ns	0.06 ± 0.01 μs	0.5 ± 0.083
polyform/iszero	1.37 ± 0.033 ms	0.836 ± 0.017 ms	1.64 ± 0.051
polyform/iszero:noop	30 ± 0 ns	0.06 ± 0.01 μs	0.5 ± 0.083
polyform/simplify_fractions	1.87 ± 0.049 ms	1.09 ± 0.021 ms	1.72 ± 0.057
time_to_load	1.03 ± 0.0045 s	1.23 ± 0.0042 s	0.836 ± 0.0046

Memory benchmarks

	master	2c8f1b8...	master / 2c8f1b8...
arithmetic/addition	1.06 k allocs: 0.0349 MB	0.439 k allocs: 12.5 kB	2.85
arithmetic/division	0.155 k allocs: 4.52 kB	0.219 k allocs: 6.42 kB	0.703
arithmetic/multiplication	5.83 k allocs: 0.168 MB	0.253 k allocs: 6.33 kB	27.2
overhead/acrule/a+2	0.061 k allocs: 2.09 kB	0.034 k allocs: 1.12 kB	1.86
overhead/acrule/a+2+b	0 allocs: 0 B	0 allocs: 0 B
overhead/acrule/a+b	0.09 k allocs: 3.19 kB	0.046 k allocs: 1.55 kB	2.06
overhead/acrule/noop:Int	0 allocs: 0 B	0 allocs: 0 B
overhead/acrule/noop:Sym	0 allocs: 0 B	0 allocs: 0 B
overhead/get_degrees/large_poly	1.45 M allocs: 0.0429 GB	0.603 M allocs: 19 MB	2.32
overhead/rule/noop:Int	2 allocs: 0.0625 kB	2 allocs: 0.0625 kB	1
overhead/rule/noop:Sym	2 allocs: 0.0625 kB	2 allocs: 0.0625 kB	1
overhead/rule/noop:Term	2 allocs: 0.0625 kB	2 allocs: 0.0625 kB	1
overhead/ruleset/noop:Int	4 allocs: 0.156 kB	0 allocs: 0 B
overhead/ruleset/noop:Sym	4 allocs: 0.156 kB	3 allocs: 0.109 kB	1.43
overhead/ruleset/noop:Term	0.063 k allocs: 2.33 kB	16 allocs: 0.453 kB	5.14
overhead/simplify/noop:Int	1 allocs: 0.0781 kB	0 allocs: 0 B
overhead/simplify/noop:Sym	1 allocs: 0.0781 kB	0 allocs: 0 B
overhead/simplify/noop:Term	0.677 k allocs: 28 kB	0.294 k allocs: 10.3 kB	2.72
overhead/simplify/randterm (+, *):serial	5.57 M allocs: 0.166 GB	2.27 M allocs: 0.0798 GB	2.08
overhead/simplify/randterm (+, *):thread	11.7 M allocs: 0.26 GB	2.3 M allocs: 0.0808 GB	3.22
overhead/simplify/randterm (/, *):serial	2.11 k allocs: 0.0779 MB	0.809 k allocs: 28.9 kB	2.76
overhead/simplify/randterm (/, *):thread	2.29 k allocs: 0.0839 MB	0.84 k allocs: 29.8 kB	2.89
overhead/substitute/a	0.807 k allocs: 26.7 kB	0.294 k allocs: 9.27 kB	2.88
overhead/substitute/a,b	0.715 k allocs: 23.6 kB	0.392 k allocs: 12.6 kB	1.88
overhead/substitute/a,b,c	0.551 k allocs: 17.6 kB	0.413 k allocs: 13.2 kB	1.33
polyform/easy_iszero	0.432 k allocs: 14.2 kB	0.157 k allocs: 4.2 kB	3.39
polyform/isone	0.0355 M allocs: 1.23 MB	11.9 k allocs: 0.557 MB	2.21
polyform/isone:noop	0 allocs: 0 B	0 allocs: 0 B
polyform/iszero	16 k allocs: 0.575 MB	9.3 k allocs: 0.45 MB	1.28
polyform/iszero:noop	0 allocs: 0 B	0 allocs: 0 B
polyform/simplify_fractions	19.7 k allocs: 0.71 MB	12.1 k allocs: 0.572 MB	1.24
time_to_load	0.159 k allocs: 11.2 kB	0.159 k allocs: 11.2 kB	1

[github-actions]

Benchmark Results (Julia vlts)

Time benchmarks

	master	2c8f1b8...	master / 2c8f1b8...
arithmetic/addition	0.0829 ± 0.0027 ms	0.0813 ± 0.0023 ms	1.02 ± 0.044
arithmetic/division	12.9 ± 0.63 μs	0.0433 ± 0.0011 ms	0.299 ± 0.016
arithmetic/multiplication	0.543 ± 0.019 ms	0.0559 ± 0.0022 ms	9.71 ± 0.52
overhead/acrule/a+2	6.53 ± 0.28 μs	2.35 ± 0.061 μs	2.77 ± 0.14
overhead/acrule/a+2+b	0.1 ± 0.01 μs	0.071 ± 0.01 μs	1.41 ± 0.24
overhead/acrule/a+b	10.6 ± 0.41 μs	4.2 ± 0.08 μs	2.52 ± 0.11
overhead/acrule/noop:Int	0.05 ± 0 μs	0.051 ± 0.01 μs	0.98 ± 0.19
overhead/acrule/noop:Sym	0.06 ± 0.01 μs	0.06 ± 0 μs	1 ± 0.17
overhead/get_degrees/large_poly	0.186 ± 0.0012 s	0.132 ± 0.0052 s	1.4 ± 0.056
overhead/rule/noop:Int	0.07 ± 0.01 μs	0.081 ± 0.01 μs	0.864 ± 0.16
overhead/rule/noop:Sym	0.07 ± 0 μs	0.07 ± 0.001 μs	1 ± 0.014
overhead/rule/noop:Term	0.07 ± 0 μs	0.07 ± 0.001 μs	1 ± 0.014
overhead/ruleset/noop:Int	0.17 ± 0.001 μs	30 ± 0 ns	5.67 ± 0.033
overhead/ruleset/noop:Sym	0.18 ± 0.01 μs	0.12 ± 0.01 μs	1.5 ± 0.15
overhead/ruleset/noop:Term	4.73 ± 0.13 μs	0.892 ± 0.02 μs	5.3 ± 0.19
overhead/simplify/noop:Int	0.311 ± 0.039 μs	30 ± 0 ns	10.4 ± 1.3
overhead/simplify/noop:Sym	0.321 ± 0.05 μs	0.04 ± 0 μs	8.03 ± 1.2
overhead/simplify/noop:Term	0.0989 ± 0.0039 ms	30.6 ± 0.82 μs	3.23 ± 0.16
overhead/simplify/randterm (+, *):serial	0.949 ± 0.013 s	0.282 ± 0.0023 s	3.37 ± 0.052
overhead/simplify/randterm (+, *):thread	0.948 ± 0.013 s	0.285 ± 0.0039 s	3.33 ± 0.064
overhead/simplify/randterm (/, *):serial	0.31 ± 0.019 ms	0.0918 ± 0.0024 ms	3.38 ± 0.22
overhead/simplify/randterm (/, *):thread	0.351 ± 0.02 ms	0.0959 ± 0.003 ms	3.67 ± 0.24
overhead/substitute/a	0.0986 ± 0.0036 ms	0.0623 ± 0.0015 ms	1.58 ± 0.069
overhead/substitute/a,b	0.0954 ± 0.0034 ms	0.0823 ± 0.002 ms	1.16 ± 0.05
overhead/substitute/a,b,c	0.0742 ± 0.0025 ms	0.0861 ± 0.0024 ms	0.861 ± 0.037
polyform/easy_iszero	0.0462 ± 0.0022 ms	30.5 ± 0.64 μs	1.52 ± 0.078
polyform/isone	3.88 ± 0.12 ms	1.19 ± 0.03 ms	3.26 ± 0.13
polyform/isone:noop	30 ± 1 ns	0.07 ± 0 μs	0.429 ± 0.014
polyform/iszero	1.59 ± 0.052 ms	1.02 ± 0.022 ms	1.55 ± 0.061
polyform/iszero:noop	30 ± 0.25 ns	0.08 ± 0.01 μs	0.375 ± 0.047
polyform/simplify_fractions	2.19 ± 0.078 ms	1.31 ± 0.037 ms	1.68 ± 0.076
time_to_load	1.02 ± 0.016 s	1.25 ± 0.043 s	0.815 ± 0.031

Memory benchmarks

	master	2c8f1b8...	master / 2c8f1b8...
arithmetic/addition	1.05 k allocs: 0.0366 MB	0.439 k allocs: 12.5 kB	2.99
arithmetic/division	0.156 k allocs: 4.84 kB	0.215 k allocs: 6.25 kB	0.775
arithmetic/multiplication	5.87 k allocs: 0.18 MB	0.257 k allocs: 6.36 kB	29.1
overhead/acrule/a+2	0.056 k allocs: 2.09 kB	0.032 k allocs: 1.16 kB	1.81
overhead/acrule/a+2+b	0 allocs: 0 B	0 allocs: 0 B
overhead/acrule/a+b	0.081 k allocs: 3.19 kB	0.043 k allocs: 1.61 kB	1.98
overhead/acrule/noop:Int	0 allocs: 0 B	0 allocs: 0 B
overhead/acrule/noop:Sym	0 allocs: 0 B	0 allocs: 0 B
overhead/get_degrees/large_poly	1.45 M allocs: 0.0429 GB	0.601 M allocs: 18.9 MB	2.32
overhead/rule/noop:Int	2 allocs: 0.0625 kB	2 allocs: 0.0625 kB	1
overhead/rule/noop:Sym	2 allocs: 0.0625 kB	2 allocs: 0.0625 kB	1
overhead/rule/noop:Term	2 allocs: 0.0625 kB	2 allocs: 0.0625 kB	1
overhead/ruleset/noop:Int	4 allocs: 0.156 kB	0 allocs: 0 B
overhead/ruleset/noop:Sym	4 allocs: 0.156 kB	3 allocs: 0.109 kB	1.43
overhead/ruleset/noop:Term	0.059 k allocs: 2.34 kB	14 allocs: 0.422 kB	5.56
overhead/simplify/noop:Int	1 allocs: 0.0781 kB	0 allocs: 0 B
overhead/simplify/noop:Sym	1 allocs: 0.0781 kB	0 allocs: 0 B
overhead/simplify/noop:Term	0.619 k allocs: 28 kB	0.274 k allocs: 10.6 kB	2.63
overhead/simplify/randterm (+, *):serial	5.21 M allocs: 0.166 GB	2.15 M allocs: 0.0815 GB	2.03
overhead/simplify/randterm (+, *):thread	5.37 M allocs: 0.171 GB	2.19 M allocs: 0.0828 GB	2.07
overhead/simplify/randterm (/, *):serial	2.05 k allocs: 0.0783 MB	0.77 k allocs: 28.6 kB	2.8
overhead/simplify/randterm (/, *):thread	2.21 k allocs: 0.0841 MB	0.805 k allocs: 29.7 kB	2.91
overhead/substitute/a	0.754 k allocs: 26.9 kB	0.299 k allocs: 9.38 kB	2.87
overhead/substitute/a,b	0.666 k allocs: 23.8 kB	0.395 k allocs: 12.7 kB	1.87
overhead/substitute/a,b,c	0.514 k allocs: 17.7 kB	0.412 k allocs: 13.3 kB	1.34
polyform/easy_iszero	0.423 k allocs: 15.1 kB	0.152 k allocs: 4.03 kB	3.74
polyform/isone	0.0327 M allocs: 1.28 MB	8.59 k allocs: 0.576 MB	2.22
polyform/isone:noop	0 allocs: 0 B	0 allocs: 0 B
polyform/iszero	14.3 k allocs: 0.598 MB	7.28 k allocs: 0.478 MB	1.25
polyform/iszero:noop	0 allocs: 0 B	0 allocs: 0 B
polyform/simplify_fractions	17.7 k allocs: 0.75 MB	9.38 k allocs: 0.6 MB	1.25
time_to_load	0.153 k allocs: 14.5 kB	0.153 k allocs: 14.5 kB	1