Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aqua.test_all triggers all deprecation warnings #83

Closed
visr opened this issue Aug 3, 2022 · 0 comments · Fixed by #89
Closed

Aqua.test_all triggers all deprecation warnings #83

visr opened this issue Aug 3, 2022 · 0 comments · Fixed by #89

Comments

@visr
Copy link

visr commented Aug 3, 2022

Recently GeometryBasics.jl added Aqua.test_all in runtests.jl. It is working well, but the package has quite a few deprecations defined in deprecated.jl.

Since adding Aqua I noticed the full list of deprecation warnings showing up each time the tests are run, here are the last few of them:

WARNING: GeometryBasics.Vec3f0 is deprecated, use Vec3f instead.
  likely near D:\visser_mn\.julia\dev\GeometryBasics\test\runtests.jl:7
WARNING: GeometryBasics.Vec4f0 is deprecated, use Vec4f instead.
  likely near D:\visser_mn\.julia\dev\GeometryBasics\test\runtests.jl:7
WARNING: GeometryBasics.Vecf0 is deprecated, use Vecf instead.
  likely near D:\visser_mn\.julia\dev\GeometryBasics\test\runtests.jl:7
Test Summary:  | Pass  Broken  Total   Time
GeometryBasics |  339       2    341  30.1s
     Testing GeometryBasics tests passed

Uncommenting Aqua.test_all makes these warnings disappear. It's not a serious issue, but it would be nice if these would not show up, since it gives the impression that deprecated bindings are being used during the tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant