Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

do not trigger deprecation warnings #89

Merged
merged 4 commits into from
Dec 20, 2022
Merged

do not trigger deprecation warnings #89

merged 4 commits into from
Dec 20, 2022

Conversation

t-bltg
Copy link
Contributor

@t-bltg t-bltg commented Nov 15, 2022

getproperty triggers deprecation warnings: avoid triggering those when walking modules.

Fix #83.

Also observed in the UnicodePlots test suite, unfortunately this PR only fixes GeometryBasics tests mentioned in the issue, we also need a PR in Reexports.jl or Colors.jl.

@codecov
Copy link

codecov bot commented Nov 15, 2022

Codecov Report

Merging #89 (95950fd) into master (7da693b) will decrease coverage by 3.17%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master      #89      +/-   ##
==========================================
- Coverage   73.54%   70.37%   -3.18%     
==========================================
  Files          10       10              
  Lines         620      621       +1     
==========================================
- Hits          456      437      -19     
- Misses        164      184      +20     
Flag Coverage Δ
unittests 70.37% <100.00%> (-3.18%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/exports.jl 88.88% <100.00%> (-11.12%) ⬇️
src/project_extras.jl 93.75% <0.00%> (-4.17%) ⬇️
src/pkg/Versions.jl 47.26% <0.00%> (-3.91%) ⬇️
src/ambiguities.jl 79.04% <0.00%> (-3.81%) ⬇️
src/deps_compat.jl 93.10% <0.00%> (-3.45%) ⬇️
src/utils.jl 91.52% <0.00%> (-1.70%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

src/exports.jl Outdated Show resolved Hide resolved
@tkf tkf enabled auto-merge (squash) December 20, 2022 16:26
@tkf tkf disabled auto-merge December 20, 2022 16:26
@tkf tkf enabled auto-merge (squash) December 20, 2022 16:26
auto-merge was automatically disabled December 20, 2022 16:30

Head branch was pushed to by a user without write access

@tkf tkf merged commit ee45d35 into JuliaTesting:master Dec 20, 2022
@t-bltg t-bltg deleted the warn branch December 20, 2022 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Aqua.test_all triggers all deprecation warnings
2 participants