Check for piracy against Base by default #101
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, libraries which pirated Base, but did not manually bring the offending function into scope was not detected. Now, default to checking Base for being a victim of piracy by default.
Codecov Report
@@ Coverage Diff @@
## master #101 +/- ##
==========================================
- Coverage 75.29% 75.03% -0.26%
==========================================
Files 11 11
Lines 676 677 +1
==========================================
- Hits 509 508 -1
- Misses 167 169 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
This feature has been included in #156 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, libraries which pirated Base, but did not manually bring the offending function into scope was not detected.
Now, default to checking Base for being a victim of piracy by default.
Edit: CI "fails" due to codecoverage acting up.