Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Work around deprecation of Base.isbindingresolved in julia nightly #322

Merged
merged 2 commits into from
Feb 6, 2025

Conversation

lgoettgens
Copy link
Collaborator

@lgoettgens lgoettgens commented Feb 6, 2025

It has been deprecated in JuliaLang/julia#57253, and this is tagged for backport to 1.12, so we ship our workaround for VERSION >= v"1.12.0-".

Copy link

codecov bot commented Feb 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.90%. Comparing base (607e012) to head (0e72672).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #322      +/-   ##
==========================================
+ Coverage   74.77%   74.90%   +0.13%     
==========================================
  Files          11       11              
  Lines         761      765       +4     
==========================================
+ Hits          569      573       +4     
  Misses        192      192              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lgoettgens lgoettgens merged commit b7d973f into JuliaTesting:master Feb 6, 2025
30 checks passed
@lgoettgens lgoettgens deleted the lg/isbindingresolved branch February 6, 2025 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant