Avoid overwrite warning using more specific method #119
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of Julia 1.10 we receive warnings like the following when running
Mocking.activate()
:As the method efinition overwrite is intentional here as we purposefully make use of invalidation to support
@mock
it would be best to silence this warning for end users.We can use the Julia flag
--warn-overwrite=no
to do this (which is the default) but runningPkg.test()
seems to enable this flag.In order to silence this error message we're now avoiding overwriting an existing method and now we are instead just defining a more specific method which ends up having the same result but without the warning. We can however no longer cleanly support multiple calls to
activate
/deactivate
as unless we want to utilize an arbitrarily deep type hierarchy. Due to this new restriction I've opted to deprecate bothdeactivate
andactivate(f)
which I'm doubtful were used externally.