Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Try not using gensym for testsetup module names #149

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
+2 −2
Draft

Try not using gensym for testsetup module names #149

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/ReTestItems.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -845,7 +845,7 @@ function ensure_setup!(ctx::TestContext, setup::Symbol, setups::Vector{TestSetup
# failed test item, we'd print the cumulative logs from all the previous attempts.
isassigned(ts.logstore) && close(ts.logstore[])
ts.logstore[] = open(logpath(ts), "w")
mod_expr = :(module $(gensym(ts.name)) end)
mod_expr = :(module $(ts.name) end)
# replace the module expr body with our @testsetup code
mod_expr.args[3] = ts.code
newmod = _redirect_logs(logs == :eager ? DEFAULT_STDOUT[] : ts.logstore[]) do
Expand Down Expand Up @@ -956,7 +956,7 @@ function runtestitem(
push!(body.args, Expr(:using, Expr(:., :Main, ts_mod)))
# ts_mod is a gensym'd name so that setup modules don't clash
# so we set a const alias inside our @testitem module to make things work
push!(body.args, :(const $setup = $ts_mod))
# push!(body.args, :(const $setup = $ts_mod))
end
@debugv 1 "Setup for test item $(repr(name)) done$(_on_worker())."

Expand Down
Loading