Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CI.yml to 1.11 release (🎉), add nightly #91

Merged
merged 2 commits into from
Oct 18, 2024
+6 −3
Merged

Update CI.yml to 1.11 release (🎉), add nightly #91

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
43506bd
Update CI.yml to 1.11 release, add nightly
NHDaly Oct 17, 2024
d7919f1
Update CI.yml: don't do all tests twice on PRs
NHDaly Oct 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions .github/workflows/CI.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,9 @@
name: CI
on:
- push
- pull_request
push:
branches: [main, master]
tags: ["*"]
pull_request:
Comment on lines -3 to +6
Copy link
Member Author

@NHDaly NHDaly Oct 17, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Taken from https://github.com/JuliaLang/Example.jl/blob/master/.github/workflows/ci.yml. I think this is better since it removes unnecessary duplication of all CI jobs - and this package already has many. :)

jobs:
test:
name: Julia ${{ matrix.version }} - ${{ matrix.os }} - ${{ matrix.arch }} - ${{ github.event_name }}
Expand All @@ -21,7 +23,8 @@ jobs:
- '1.8'
- '1.9'
- '1.10'
- '^1.11.0-beta2'
- '1.11'
- 'nightly'
Comment on lines -24 to +27
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is nightly the right thing here? Do you usually use something more specific on 1.12.0-*?

os:
- ubuntu-latest
- windows-latest
Expand Down
Loading