Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for duplicate properties #110

Merged
merged 3 commits into from
May 17, 2024
Merged

Allow for duplicate properties #110

merged 3 commits into from
May 17, 2024

Conversation

omus
Copy link
Member

@omus omus commented May 4, 2024

Overview of the work done here:

Extracted from #106 to make reviewing easier.

@omus omus requested a review from oxinabox May 7, 2024 13:36
src/testsets.jl Outdated Show resolved Hide resolved
Copy link
Member

@oxinabox oxinabox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one is definately breaking. Which is fine.
I agree with the spirit of this

Copy link
Member

@oxinabox oxinabox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
merge this and rebase the other and i will wrap up review of that then we can tag a breaking release

Co-authored-by: Frames White <oxinabox@ucc.asn.au>
@omus omus merged commit 98ffbf0 into master May 17, 2024
10 checks passed
@omus omus deleted the cv/duplicate-properties branch May 17, 2024 14:54
@omus omus mentioned this pull request May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants