Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disable fail-fast on GHA CI #328

Closed
wants to merge 1 commit into from
Closed

Conversation

oxinabox
Copy link
Contributor

Fail-fast on GHA doesn't work great.
The benchmark job erroring shouldn't prevent the actual testing jobs from running.
Since the benchmarking job can error if you change how any types are defined #327 (comment)

@codecov-io
Copy link

codecov-io commented Apr 13, 2021

Codecov Report

Merging #328 (5808d45) into master (906cea0) will decrease coverage by 0.20%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #328      +/-   ##
==========================================
- Coverage   93.80%   93.59%   -0.21%     
==========================================
  Files          32       32              
  Lines        1534     1531       -3     
==========================================
- Hits         1439     1433       -6     
- Misses         95       98       +3     
Impacted Files Coverage Δ
src/compat.jl 0.00% <0.00%> (-100.00%) ⬇️
src/types/zoneddatetime.jl 96.00% <0.00%> (-0.06%) ⬇️
src/parse.jl 94.44% <0.00%> (-0.02%) ⬇️
src/tzdata/compile.jl 95.50% <0.00%> (+0.32%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 906cea0...5808d45. Read the comment docs.

@omus
Copy link
Member

omus commented Apr 30, 2021

Are you sure fast-fail works this way? Seems strange that it looks at jobs that aren't part of it's on matrix

@oxinabox
Copy link
Contributor Author

No, I am not sure.

@omus
Copy link
Member

omus commented Apr 30, 2021

When set to true, GitHub cancels all in-progress jobs if any matrix job fails. Default: true
https://docs.github.com/en/actions/reference/workflow-syntax-for-github-actions#jobsjob_idstrategyfail-fast

Seems like this documentation is wrong then. Would be good to open an issue.

@omus
Copy link
Member

omus commented Dec 2, 2021

So the solution to this is to actually set fast-fail: false on just the benchmark job. With this then a failure from the benchmark job will not impact any other running job but jobs with fast-fail: true will cause other jobs to be cancelled. I'll make a PR for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants