Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Julia 0.7 syntax #88

Merged
merged 7 commits into from
Sep 9, 2017
Merged

Update to Julia 0.7 syntax #88

merged 7 commits into from
Sep 9, 2017

Conversation

omus
Copy link
Member

@omus omus commented Sep 6, 2017

Drops support for Julia 0.4 and 0.5. Replaces #85

@omus omus self-assigned this Sep 6, 2017
@omus omus mentioned this pull request Sep 6, 2017
@omus
Copy link
Member Author

omus commented Sep 6, 2017

AppVeyor failures appear to be JuliaPackaging/WinRPM.jl#57

@JeffreySarnoff
Copy link
Member

why would that failure occur here and not before these edits?

@codecov-io
Copy link

Codecov Report

Merging #88 into master will increase coverage by 27.86%.
The diff coverage is 85.71%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master      #88       +/-   ##
===========================================
+ Coverage   63.79%   91.65%   +27.86%     
===========================================
  Files          26       26               
  Lines        1428      959      -469     
===========================================
- Hits          911      879       -32     
+ Misses        517       80      -437
Impacted Files Coverage Δ
src/exceptions.jl 100% <ø> (+40%) ⬆️
src/interpret.jl 100% <ø> (+33.33%) ⬆️
src/utcoffset.jl 100% <ø> (+40.62%) ⬆️
src/conversions.jl 100% <ø> (+44%) ⬆️
src/tzfile.jl 97.05% <ø> (+29.71%) ⬆️
src/adjusters.jl 100% <ø> (+33.33%) ⬆️
src/tzdata/compile.jl 92.88% <ø> (+29.14%) ⬆️
src/types.jl 95.06% <ø> (+29.73%) ⬆️
src/tzdata/timeoffset.jl 93.1% <0%> (+24.05%) ⬆️
src/tzdata/archive.jl 100% <100%> (+34.14%) ⬆️
... and 26 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b8a8cbd...89ae369. Read the comment docs.

@omus
Copy link
Member Author

omus commented Sep 9, 2017

why would that failure occur here and not before these edits?

The issue had to do with a package server being down. Looks like it's working again and re-running the failed jobs now works.

@omus omus merged commit ec5ab48 into master Sep 9, 2017
@omus omus deleted the for-v0.7 branch September 9, 2017 16:00
@JeffreySarnoff
Copy link
Member

JeffreySarnoff commented Sep 9, 2017

yar, thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants