-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for writing parallel structured VTK formats (.pvti / .pvtr / .pvts) #98
Add support for writing parallel structured VTK formats (.pvti / .pvtr / .pvts) #98
Conversation
@amartinhuertas maybe you have some ideas on how to improve this PR? |
Thanks! I'm not yet sure about the best solution for the WholeExtent issue, but I think it's best to avoid depending on MPI. I guess one simple solution would be to ask the user to explicitly pass |
Codecov Report
@@ Coverage Diff @@
## master #98 +/- ##
==========================================
+ Coverage 95.58% 96.01% +0.43%
==========================================
Files 16 16
Lines 770 803 +33
==========================================
+ Hits 736 771 +35
+ Misses 34 32 -2
Continue to review full report at Codecov.
|
- remove checks and simplify signatures - they must now be passed as one-based ranges, and converted to zero-based for writing to VTK files
…ctured Parallel files
063adcd
to
1974f60
Compare
I think I got all structured formats working correctly. For now the partitioning must be specified by passing an I'm open to other ways of specifying the extents, but I'd prefer if we could avoid depending on MPI. If it's really worth it, we could try to support MPI via Requires. I'll try to add some examples to the documentation. Besides, one annoying thing about parallel structured grids in VTK is that subdomains must overlap, or otherwise VTK (or at least ParaView) complains when loading the files. I'll mention this in the documentation. |
Good, I hope my work helped a bit ;-) I'll try to use it in a parallel, though I don't have overlap, so we will see how it is handled... |
Here is a PR to close issue #91
What was added : support for
PRectilinearGrid
,PStructuredGrid
andPImageData
.WholeExtent
needs to be improved. I am tempted to suggest usingMPI
here, but it would add a dependency? Any idea about this?