Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

@async POST not asynchronous #130

Closed
samoconnor opened this issue Nov 29, 2017 · 0 comments
Closed

@async POST not asynchronous #130

samoconnor opened this issue Nov 29, 2017 · 0 comments

Comments

@samoconnor
Copy link
Contributor

This test is supposed to send a POST body asynchronously:

HTTP.jl/test/client.jl

Line 156 in d6804f0

write(f, " there ") # as we write to f, it triggers another chunk to be sent in our async request

However, connectandsend buffers the entire request into a String before doing a single write to the socket:

HTTP.jl/src/client.jl

Line 235 in d6804f0

reqstr = string(req, opts)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@samoconnor