Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

logbody = false causes body not to be sent to socket #131

Closed
samoconnor opened this issue Nov 29, 2017 · 0 comments
Closed

logbody = false causes body not to be sent to socket #131

samoconnor opened this issue Nov 29, 2017 · 0 comments

Comments

@samoconnor
Copy link
Contributor

I've put a println(reqstr) in connectandsend just before @retryif Base.UVError write(conn.socket, reqstr) to see what gets sent over the socket.

When I do HTTP.get("http://httpbin.org/ip"; logbody=false), I see this...

GET /ip HTTP/1.1
User-Agent: HTTP.jl/0.0.0
Accept: text/html,application/xhtml+xml,application/xml;q=0.9,*/*;q=0.8,application/json; charset=utf-8
Host: httpbin.org

[request body logging disabled]

Looks related to #130. i.e. request if buffered into a string by the same body(::io, ...) method that is used for logging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant