-
Notifications
You must be signed in to change notification settings - Fork 181
Closed
Labels
serverAbout our HTTP serverAbout our HTTP server
Description
This code should not use @eval, since changing the dispatch table can have poorly-controlled side effects:
Lines 410 to 417 in 209f10e
| @eval function HTTP.Handlers.gethandler(r::$(Expr(:$, :(typeof($router)))), | |
| ::(HTTP.Handlers.gh($method)), | |
| ::(HTTP.Handlers.gh($scheme)), | |
| ::(HTTP.Handlers.gh($host)), | |
| $(Expr(:$, vals)), | |
| args...) | |
| return $(Expr(:$, handler)) isa HTTP.Handler ? $(Expr(:$, handler)) : HTTP.Handlers.RequestHandlerFunction($(Expr(:$, handler))) | |
| end |
c42f and eliascarveliascarv
Metadata
Metadata
Assignees
Labels
serverAbout our HTTP serverAbout our HTTP server