Backport "Make CI green again (#1128)" to v1.9 #1152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quinnj
approved these changes
Feb 17, 2024
* Fix tests for new version of `ConcurrentUtilities` `ConcurrentUtilities` changed an (internal) fieldname of the `Pool` type from `max` to `limit`. This field is used in HTTP.jl tests so this patch works around the issue. * Remove invalidation CI check This has been failing for quite some time with some internal error. Also in the working case it is a bit unclear what the actionable thing is when it errors (xref #920 (comment)).
nickrobinson251
force-pushed
the
npr-concurrentutilites-fix-1.9
branch
from
cd03ebc
to
5ab8303
Compare
Fixed it: 6a3b0a9 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release-1.9 #1152 +/- ##
==============================================
Coverage ? 82.49%
==============================================
Files ? 32
Lines ? 3051
Branches ? 0
==============================================
Hits ? 2517
Misses ? 534
Partials ? 0 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@quinnj spotted CI failed when the last PR to
release-1.9was merged: https://github.com/JuliaWeb/HTTP.jl/actions/runs/7929317925/job/21649293467Hopefully this fixes it 🤞
ConcurrentUtilitiesConcurrentUtilitieschanged an (internal) fieldname of thePooltype frommaxtolimit. This field is used in HTTP.jl tests so this patch works around the issue.This has been failing for quite some time with some internal error. Also in the working case it is a bit unclear what the actionable thing is when it errors (xref
#920 (comment)).