add CURLOPT_MAXAGE_CONN #99
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added const for `CURLOPT_MAXAGE_CONN` definition and exported it. Useful to control how curl reuses connections. While the other most options for long lived connections are already present, connection maxage is also critical for cases where multiplexing is enabled.
Codecov Report
@@ Coverage Diff @@
## master #99 +/- ##
=======================================
Coverage 20.86% 20.86%
=======================================
Files 2 2
Lines 139 139
=======================================
Hits 29 29
Misses 110 110 Continue to review full report at Codecov.
|
|
While I did try to regenerate the code, I faced the same issues as discussed here. This is just a const definition, and manual change should be safe at this point I believe. |
quinnj
approved these changes
Mar 17, 2021
|
SGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added const for
CURLOPT_MAXAGE_CONNdefinition and exported it.Useful to control how curl reuses connections.
While the other most options for long lived connections are already present, connection maxage is also critical for cases where multiplexing is enabled. The default maxage of 118 seconds is often too less in such cases.
Also corrected
CURLOPT_LASTENTRYto reflect the value as per v7.73 as used in LibCURL_jll at the moment.