Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes for Julia 0.7 #6

Merged
merged 3 commits into from
Jul 20, 2018
Merged

Fixes for Julia 0.7 #6

merged 3 commits into from
Jul 20, 2018

Conversation

ararslan
Copy link
Member

No description provided.

@ararslan ararslan mentioned this pull request Jul 19, 2018
Merged
@ararslan ararslan changed the title Fixes for Julia 0.7 WIP: Fixes for Julia 0.7 Jul 19, 2018
@samoconnor
Copy link
Collaborator

Thanks for this @ararslan.
I'd prefer this PR to not use Compat and drop Julia 0.6 support.
I would really like to try to avoid breaking any existing Julia 0.6 AWSCore based production code by introducing a subtle bug in the process of 0.7 updates.

@samoconnor samoconnor mentioned this pull request Jul 19, 2018
Closed
@ararslan
Copy link
Member Author

I've removed Compat and set the minimum version to 0.7.

@ararslan ararslan changed the title WIP: Fixes for Julia 0.7 Fixes for Julia 0.7 Jul 19, 2018
@samoconnor samoconnor merged commit 9decefd into JuliaWeb:master Jul 20, 2018
@ararslan ararslan deleted the aa/0.7 branch July 20, 2018 02:03
@ararslan
Copy link
Member Author

Thanks! Could I trouble you for a tag here too? 😁

@samoconnor
Copy link
Collaborator

JuliaLang/METADATA.jl#16029

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ararslan @samoconnor