joinpath & allow kwargs in constructor #12
Conversation
|
@c42f bump |
|
PS. can we have a new tag after this gets merged? I kinda want to release my package with this new interface directly instead of updating later... |
| if isempty(uri.path) | ||
| path = "/" * path | ||
| end | ||
| return URI(uri; path=normpath(path)) |
There was a problem hiding this comment.
I'd rather avoid normpath as that uses system-dependent regexes to parse the path (including drive letters and such, on windows).
There was a problem hiding this comment.
Let's follow the exact rules in RFC1808 section 4 I guess?
There was a problem hiding this comment.
I think this normpath calls the URLs.normpath: https://github.com/JuliaWeb/URIs.jl/blob/master/src/URIs.jl#L415 which follows https://tools.ietf.org/html/rfc3986#section-5.2.4 already @c42f
There was a problem hiding this comment.
Oh dear, yes indeed!
This is what happens when trying to maintain a package I seem to have inherited by accident 😆
Co-authored-by: Chris Foster <chris42f@gmail.com>
|
Thanks, this is very nice. I'm sure it will be useful. |
|
New version: JuliaRegistries/General#25219 |
@c42f I implemented the
joinpathandURImentioned in #10