Fix leading slash for abspath in joinpath #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Peter Bräuer <pb866.git@gmail.com>
Add tests to add absolut path with and without trailing slash and absolut path with additional part to an empty uri path. Signed-off-by: Peter Bräuer <pb866.git@gmail.com>
|
Is there anything that needs to be done before this can be merged? I think, the failing test has nothing to do with this fix. An alternative fix would be to ensure non-empty URI paths, so the condition that was adjusted in this PR is not needed at all. This is also a workaround for the current situation (without tempering with the package's code), but it would be nice to have a proper resolution one way or the other. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently,
joinpathgives two leading slashes, when an absolute path is joined to an empty URI path. This PR fixes this issue.