Fixed issue with optional schemas #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
undefined variables are now unset instead of 'undefined'
|
Thanks dude ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a Schema, either built-in or via zod has an optional variable, which results in the validation result being undefined, the corresponding env-variable is set to 'undefined', because of the implicit string conversion via process.env.
This however does not match the types generated for the
import.meta.envand is, at least imo, not what I'd expect to happen.This PR fixes that issue, by unsetting any env-variable, which is
undefinedafter validation and adds tests for this case.I adapted the test-files slightly to fix any eslint/prettier warnings as well, but we can roll this back again :)