Create button component #6
Open
+82
−143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sristii
approved these changes
Dec 12, 2024
| @@ -1,101 +1,29 @@ | |||
| import Image from "next/image"; | |||
| import Button from "@/app/components/button"; | |||
| import { EnvelopeIcon } from "@heroicons/react/20/solid"; | |||
There was a problem hiding this comment.
LOOKS GREAT SO FAR - can we match the design a bit more by changing this to be the outline version of the icon, instead of solid?
Suggested change
| import { EnvelopeIcon } from "@heroicons/react/20/solid"; | |
| import { EnvelopeIcon } from "@heroicons/react/20/outline"; |
if there was a specific reason for using solid icons tho, nw! just document why :-)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Builds a standard reusable button component. The button is currently visible on the index (
/) page.Also does some one-time cleanup on the boilerplate that came with Next.js.
Issues
Half of #2.
Screenshots
Test
Open
/and see the buttons!Possible Downsides
None that I can think of!
Additional Documentations
See typed props in
app/components/button.tsx.