Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Completed customer survey questions #36

Merged
merged 3 commits into from
Nov 27, 2024
Merged

Completed customer survey questions #36

merged 3 commits into from
Nov 27, 2024

Conversation

zoyaamrit
Copy link
Collaborator

Tanisha and Zoya: Ticket 26

25/11/2024

The input boxes are not as wide as on the design but there's some bug whenever we tried to increase the size beyond w-96!

@zoyaamrit zoyaamrit requested a review from jiyoonchoi November 25, 2024 20:00
jiyoonchoi
jiyoonchoi approved these changes Nov 27, 2024
View reviewed changes
Copy link
Collaborator

@jiyoonchoi jiyoonchoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! I added some extra code:

  1. Added an onChange prop to Phone Number to later retrieve the inputted data
  2. Updated the input borders to be light gray
  3. Added a temporary confirmation page (client recently told us to add this)

@jiyoonchoi jiyoonchoi merged commit 4e2864b into dev Nov 27, 2024
1 check failed
@jiyoonchoi jiyoonchoi deleted the frontend/26-customer-pages-2 branch November 27, 2024 23:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jiyoonchoi jiyoonchoi jiyoonchoi approved these changes

Assignees

@zoyaamrit zoyaamrit

@tanishalaud01 tanishalaud01

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zoyaamrit @jiyoonchoi @tanishalaud01