[syslog] enable/disable syslog rate limit feature in fixture #91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Junchao-Mellanox
changed the title
keboliu
approved these changes
Dec 11, 2023
Junchao-Mellanox
force-pushed
the
master-en-syslog
branch
from
75f2e91 to
391b2a0
Compare
Change-Id: I61545db602d579fa0f337686427235c6d04998c7
Junchao-Mellanox
force-pushed
the
master-en-syslog
branch
from
391b2a0 to
c4015ac
Compare
nhe-NV
approved these changes
Dec 11, 2023
JibinBao
approved these changes
Dec 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
Feature syslog rate limit has been disabled by default to avoid consume CPU cycles during warm / fast reboot. There are new CLIs to enable/disable it. The PR is to automatically enable it before syslog rate limit test and disable it after.
Summary:
In fixture "restore_rate_limit", enable the feature at beginning, disable the feature at the end.
Type of change
[ ] Bug fix
[ ] Testbed and Framework(new/improvement)
[x] Test case(new/improvement)
Back port request
[ ] 201911
[ ] 202012
[ ] 202205
[x] 202305
Approach
In fixture "restore_rate_limit", enable the feature at beginning, disable the feature at the end.
What is the motivation for this PR?
Align test code with production code change
How did you do it?
In fixture "restore_rate_limit", enable the feature at beginning, disable the feature at the end.
How did you verify/test it?
Run test case on local setup, all passed
Any platform specific information?
N/A
Supported testbed topology if it's a new test case?
N/A
Documentation