add UDP telemetry support #7
Conversation
| @@ -23,6 +23,7 @@ var ( | |||
| prom = flag.Bool("prometheus", false, "Stats for prometheus monitoring system") | |||
| promHost = flag.String("prometheus-host", "127.0.0.1", "IP to bind Prometheus service to") | |||
| promPort = flag.Int32("prometheus-port", 8090, "Prometheus port") | |||
| udp = flag.Bool("udp", false, "Stats for udp monitoring system") | |||
There was a problem hiding this comment.
Why CLI option given that there is already udp in .json file ?
There was a problem hiding this comment.
Thanks so much for advice. Please find the changes in commit remove udp CLI option.
| type UDPConfig struct { | ||
| Port int `json:"port"` | ||
| Host string `json:"host"` | ||
| Protos []string `json:"protos"` |
There was a problem hiding this comment.
Makefile target to compile protos are missing ?
There was a problem hiding this comment.
Given that the user may not provide specific proto files in the JTIMON config, and it may be time consuming to compile all the protos, therefore I just uploaded all the .pb.go files along with the proto files under /schema.
I'd love to add make proto in the Makefile as needed.
Just to clarify, the Makefile target is expected to compile all the protos?
|
unit tests are missing. |
|
The existing tests are broken. |
Please run |
|
You cant expect users to run go mod tidy, etc. You need to commit the dependencies. |
|
Any news on this? |
|
We have MX104 that we want to collect telemetry from. It only supports UDP. But Jtimon doesn't support it. Any ideas how to capture udp and translate into prometheus metric? |
Add UDP support, feed the telemetry data onto InfluxDB.
Issue: Add UDP telemetry support #6
Please start JTIMON as shown below.
$ ./jtimon-linux-amd64 --config udp.json --udp --printwhere udp.json is following
{ "udp": { "host": "your-junos-ip-or-hostname", "port": UDP-Port-Number }, "influx": { "server": "127.0.0.1", "port": 8086, "dbname": "mydb", "user": "influx", "password": "influxdb", "recreate": true } }