Saltstack: salt execution module junos.rpc options format and dest works only with get-config rpc

[rsmekala]

Description of Issue/Question

The current logic around optionsdest and format is incorrect. In salt, the module arguments are published under kwargs['__pub_arg'] but the current logic searches for format under kwargs directly.

dest is being handled as a positional argument only not as a keywod argument.

Logs:

➜ salt 'vmx' junos.rpc get-software-information format=text

vmx:
    ----------
    message:
        RPC execution failed due to "RpcError(severity: error, bad_element: format, message: error: syntax error, expecting <invoke-on>
        error: syntax error)"
    out:
        False

➜ salt 'vmx' junos.rpc get-software-information dest=/tmp/cli.out

vmx:
    ----------
    message:
        RPC execution failed due to "RpcError(severity: error, bad_element: dest, message: error: syntax error, expecting <invoke-on>
        error: syntax error)"
    out:
        False

[rsmekala]

Closed PR: 1428147