Bug fixes in Junos-related components

[rsmekala]

What does this PR do?

Multiple bug fixes were done for Junos-related components in salt.

What issues does this PR fix or reference?

• Fixes install_config times out on longer commit checks Juniper/salt#85, Salt execution module junos.cli with invalid dest="" throws exception FileNotFoundError: [Errno 2] No such file or directory Juniper/salt#86, Wrong documentation under junos.diff CLI section Juniper/salt#88, Saltstack: salt execution module junos.rpc options format and dest works only with get-config rpc  Juniper/salt#89, Saltstack:salt execution module junos.rpc get-config invalid filter throws SyntaxError exception Juniper/salt#90, salt execution module junos.rollback CLI example syntax is not correct (salt 'device_name' junos.rollback 10) Juniper/salt#93, salt execution module junos.load and junos.install_config with invalid config files throws exception AttributeError: 'bool' object has no attribute 'read Juniper/salt#94, Applying salt state file with function junos.diff fails with TypeError: diff() missing 1 required positional argument: 'd_id' Juniper/salt#96, Applying salt state file with funciton junos.rpc fails with TypeError: rpc() takes at most 2 arguments (3 given) Juniper/salt#99, Exception emitted on salt-master [ERROR ] Unhandled exception running status.proxy_reconnect after junos.zeroize . Juniper/salt#100, salt execution module junos.install_config with invalid mode throws exception ValueError: unsupported action: test  Juniper/salt#103, salt execution module junos.install_config with mode dynamic throws exception RpcError: RpcError(severity: error, bad_element: None, message: error: statement creation failed: version Juniper/salt#104, salt execution module junos.install_os with invalid image name throws exception and help information is not dispalyed Juniper/salt#109, Saltstack:salt execution module junos.install_os default installs the image on Master RE , options are not available to select dual RE , back up RE Juniper/salt#110, salt execution module junos.rpc CLI example syntax is not correct (salt 'device' junos.rpc get-interface-information /home/user/interface.xml) Juniper/salt#112, Only one config action has to be supported, currently multiple config actions are supported Juniper/salt#113, Add merge option to load() to match PyEZ capabilities Juniper/salt#114, salt executiom module junos.install_os with dev_timout fails with Installation failed due to: "pkgadd() got multiple values for keyword argument 'dev_timeout'" Juniper/salt#117

Tests written?

Yes

[vnitinv]

Also need to now use pre-commit and black for PR submissions. They will be run as part of the PR test etc. but good to catch issues beforehand. Check https://github.com/saltstack/salt-enhancement-proposals/blob/master/accepted/0015-black.md where it was discussed.

Apart from changing published interfaces it looks good, published interfaces have to go through a deprecation cycle (used to be two major releases) if the changes are not backwards compatible, that is, can extend them, but should not affect existing parameters.

Used pre-commit tools and also done suggested changes like a single quote to double.
Also added dependencies list in Linux and darwin files.

[dmurphy18]

Interfaces cannot change without deprecation cycles, new interfaces can be added to address desired changes and the old interfaces marked for deprecation, which typically are removed after two major release cycles. Existing customers cannot have interfaces changes without time to accommodate them.

[dmurphy18]

see reply for salt/states/junos.py about deprecation cycle and changing interfaces

[dmurphy18]

see reply for salt/states/junos.py about deprecation cycle and changing interfaces
The label of a positional argument doesn't really matter here compared to a documentation typo/error, but the positional argument is required otherwise the interface is changing without a deprecation cycle for the interface

[vnitinv]

@dmurphy18 Check if the changes are good now?

[vnitinv]

Hi @sagetherage @cro @dmurphy18, Please help in getting this to closure. We want this to be part of Sodium release. Let us know if anything is to be done from our side.

[sagetherage]

I have followed up internally as well @vnitinv with David Murphy and he will respond by no later than end of day, Monday 2020-04-27, he may respond sooner.

[dmurphy18]

Apart from adding versionchanged for 'def diff' for the new extra kwargs, everything looks good, review wise.

[dmurphy18]

Thanks for the work

[dmurphy18]

@vnitinv Some failing tests that need to be fixed before can merge

[vnitinv]

@dmurphy18 I have fixed pre-commit failures.

For ci/py3/macosxmojave looks like there is something that needs to be done from salt backend. Check the existing issue related to enum failure of Mac. #56603