Fixes multiple PRs raised by Test team #107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fixes #112 |
|
Fixes #109 |
|
Fixes #115 |
rsmekala
changed the title
vnitinv
reviewed
Apr 25, 2019
salt/modules/junos.py
Outdated
|
|
||
| if check and not test: | ||
| if db_mode == 'dynamic' or check and not test: |
There was a problem hiding this comment.
can you just use default value for check and then we wont need this line change
There was a problem hiding this comment.
commit_check returns True if commit_check succeeds, else raises an exception.
vnitinv
reviewed
Apr 25, 2019
| ret['message'] = 'Invalid image path.' | ||
| ret['out'] = False | ||
| return ret | ||
| if not os.path.isfile(image_cached_path): |
vnitinv
reviewed
Apr 25, 2019
salt/modules/junos.py
Outdated
| @@ -1510,7 +1555,7 @@ def get_table(table, table_file, path=None, target=None, key=None, key_items=Non | |||
| except Exception as err: | |||
| ret['message'] = 'Uncaught exception - please report: {0}'.format( | |||
| str(err)) | |||
| traceback.print_exc() | |||
|
|
|||
|
@vnitinv Also updated the comment as requested. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #104