Update CT resource batch_id
plan modifiers to handle unknown
children
#1023
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It turns out that #1017 fixed a related issue, but not the exact problem faced by @coterv in #1012.
Both issues are in the plan modifier for the CT primitive
batch_id
attribute.@coterv's configuration causes the plan modifier to run while the details of child primitives are in
Unknown
state.Prior to these changes, the plan modifier counts those not-yet-available child primitives, concludes that none exist, and sets the
batch_id
attribute tonull
(there are no children, so there won't be a child container, so the ID is moot).Later, when the child primitives are fully fleshed out (upstream dependencies are satisfied), the plan modifier runs again. This time, when it counts the child primitives, it finds a non-zero number and sets the
batch_id
toUnknown
(there will be a child container object, and it will have an ID).Terraform complains about this inconsistent planning behavior:
batch_id: was null, but now cty.UnknownVal(cty.String)
Closes #1012