Bugfix: Populate missing name/id attributes in apstra_datacenter_system
data source
#364
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
apstra_datacenter_system
takes eithername
orid
as input and populates system details in an object calledattributes
.The
attributes
object has bothname
andid
inside.Prior to this PR, nothing was populating the top-level (input)
name
orid
other than the user. One of those two fields (whichever the user didn't use) would always be Null when the data source returned.This PR ensures that the top-level
name
andid
fields are both always populated making it safe for the user to refer todata.apstra_datacenter_system.<name>.id
, rather thandata.apstra_datacenter_system.<name>.attributes.id
Also, the
ReadFromApi()
method has been renamedAttributesFromApi()
to make it clear that only theattributes
object is being populated.