-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Also complete symbols when completing keyword arguments #15
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #15 +/- ##
===========================================
+ Coverage 57.71% 72.69% +14.98%
===========================================
Files 1 1
Lines 428 597 +169
===========================================
+ Hits 247 434 +187
+ Misses 181 163 -18
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
This needs to add the change from JuliaLang/julia@d0f4327 for VERSION > 1.9, will do later (UPDATE: Done!). |
@Pangoraw can you take a look at the failed kwarg tests on Julia 1.6? |
That should be fixed by #18! Bug was introduced in da79850 Edit: oh you mean
I will look into it. |
this was introduced in JuliaLang/julia#43536
Fixed by disabling tests, keyword completion was only introduced in 1.9. |
The commented line had the effect of disabling symbol completions for queries like
sin(sin
(see fonsp/Pluto.jl#2629).I added with a non-fuzzy completion from the REPLCompletions module to improve the results in this case. I am very much open to other more optimal solutions.