Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Also complete symbols when completing keyword arguments #15

Merged
merged 4 commits into from
Mar 13, 2024

Conversation

Pangoraw
Copy link
Contributor

The commented line had the effect of disabling symbol completions for queries like sin(sin (see fonsp/Pluto.jl#2629).

I added with a non-fuzzy completion from the REPLCompletions module to improve the results in this case. I am very much open to other more optimal solutions.

@codecov-commenter
Copy link

codecov-commenter commented Aug 24, 2023

Codecov Report

Attention: Patch coverage is 83.33333% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 72.69%. Comparing base (f4b049e) to head (e2165a7).
Report is 2 commits behind head on master.

Files Patch % Lines
src/FuzzyCompletions.jl 83.33% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           master      #15       +/-   ##
===========================================
+ Coverage   57.71%   72.69%   +14.98%     
===========================================
  Files           1        1               
  Lines         428      597      +169     
===========================================
+ Hits          247      434      +187     
+ Misses        181      163       -18     
Flag Coverage Δ
unittests 72.69% <83.33%> (+14.98%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Pangoraw
Copy link
Contributor Author

Pangoraw commented Aug 24, 2023

This needs to add the change from JuliaLang/julia@d0f4327 for VERSION > 1.9, will do later (UPDATE: Done!).

@pfitzseb pfitzseb closed this Mar 12, 2024
@pfitzseb pfitzseb reopened this Mar 12, 2024
@fonsp
Copy link
Contributor

fonsp commented Mar 12, 2024

@Pangoraw can you take a look at the failed kwarg tests on Julia 1.6?

@Pangoraw
Copy link
Contributor Author

Pangoraw commented Mar 12, 2024

@Pangoraw can you take a look at the failed kwarg tests on Julia 1.6?

That should be fixed by #18! Bug was introduced in da79850

Edit: oh you mean

Keyword Argument Completion: Test Failed at /home/runner/work/FuzzyCompletions.jl/FuzzyCompletions.jl/test/runtests.jl:104
  Expression: comp("sum(x; dim") == "dims="
   Evaluated: "Dims" == "dims="

I will look into it.

@Pangoraw
Copy link
Contributor Author

Fixed by disabling tests, keyword completion was only introduced in 1.9.

@fonsp
Copy link
Contributor

fonsp commented Mar 13, 2024

@pfitzseb

@pfitzseb pfitzseb merged commit 7888685 into JunoLab:master Mar 13, 2024
20 checks passed
@Pangoraw Pangoraw deleted the keyword_sym branch March 20, 2024 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants