Update complete_symbol with changes from https://github.com/JuliaLang/julia/pull/49206
#14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This updates the code taken from `REPL.REPLCompletions` with the changes introduced in JuliaLang/julia#49206. Otherwise, `using FuzzyCompletions` will complain about `get_type` and `get_value` being undefined when precompiling and completely fail when being used on the upcoming Julia 1.10 release. Co-authored-by: Shuhei Kadowaki <aviatesk@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #14 +/- ##
==========================================
+ Coverage 57.38% 57.71% +0.32%
==========================================
Files 1 1
Lines 413 428 +15
==========================================
+ Hits 237 247 +10
- Misses 176 181 +5
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
@aviatesk Could you take a look? This is required to support Julia 1.10 |
|
I also bumped the version number in this PR (to 0.5.2) as it would be nice to have into a release for 1.10 users. |
|
Sorry for being super late to review this. Looks great. Thanks for your help! |
|
Test failures are due to changes made in #50412. I added additional change to make it pass tests (it turns out that our tests are not very robust against the changes in the |
|
And the failures in 1.6 are due to inferrability issues, which nobody would care at this point. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the code taken from
REPL.REPLCompletionswith the changesintroduced in JuliaLang/julia#49206.
Otherwise,
using FuzzyCompletionswill complain aboutget_typeandget_valuebeing undefined when precompiling and completely fail whenbeing used on the upcoming Julia 1.10 release.
Fixes #13.