Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rename refactor #236

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

rename refactor #236

wants to merge 2 commits into from

Conversation

aviatesk
Copy link
Member

@aviatesk aviatesk commented Oct 23, 2019 •
edited
Loading

aviatesk
aviatesk commented Oct 23, 2019
View reviewed changes
lib/plots/canopy.js Outdated Show resolved Hide resolved
This was referenced Oct 23, 2019
Merged
Open
@aviatesk aviatesk force-pushed the avi/renamerefactor branch 2 times, most recently from c4ec0ee to 717b5f5 Compare November 11, 2019 23:27
@aviatesk aviatesk force-pushed the avi/renamerefactor branch 2 times, most recently from c4440db to cad5c30 Compare December 20, 2019 09:51
@aviatesk aviatesk force-pushed the avi/renamerefactor branch 2 times, most recently from e226cca to 6493bb4 Compare February 7, 2020 14:58
@aviatesk aviatesk force-pushed the avi/renamerefactor branch 2 times, most recently from 1d615ed to 6c463f5 Compare February 15, 2020 18:37
@aviatesk
refactor on showBasicModal
b190b89 
- export it
- add message
- handle all the rejections
- const over let
@aviatesk
eslint stuff
62d963a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pfitzseb pfitzseb pfitzseb left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aviatesk @pfitzseb