Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix reserved keywork package #85

Merged
merged 2 commits into from
Apr 14, 2023
Merged

fix reserved keywork package #85

merged 2 commits into from
Apr 14, 2023

Conversation

sertonix
Copy link
Contributor

@sertonix sertonix commented Jan 6, 2023

Since Atom was killed the community came together and made a fork called [Pulsar}(https://github.com/pulsar-edit/pulsar).
It has updated a lot of parts in the editor.
This also changed the javascript version that was used. In the newer one package is a keyword and can't be used as variable name.
This fixes the issue.

It would be nice if a new version with this fix could be published to the new packend. If there are any problems you can create an issue on the github repo.

@sertonix sertonix changed the title fix package not working on pulsar fix reserved keywork package Jan 6, 2023
@goyalyashpal
Copy link
Contributor

@pfitzseb @MikeInnes Please review 😃

Co-authored-by: goyalyashpal <yashpalgoyal1304@gmail.com>
@pfitzseb pfitzseb merged commit 09eee8d into JunoLab:master Apr 14, 2023
@sertonix sertonix deleted the patch-1 branch April 15, 2023 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants