Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

INT-9221 - add auto release and adjust workflows #68

Merged
merged 2 commits into from
Aug 30, 2023
Merged

Conversation

RonaldEAM
Copy link
Contributor

Description

Thank you for contributing to a JupiterOne integration!

Please include a summary of the change and which issue is fixed. Please also
include relevant motivation and context. List any dependencies that are required
for this change.

Summary

Type of change

Please leave any irrelevant options unchecked.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to
    not work as expected)
  • This change requires a documentation update

Checklist

General Development Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Integration Development Checklist:

Please leave any irrelevant options unchecked.

  • I have checked for additional permissions required to call any new API
    endpoints, and have documented any additional permissions in
    jupiterone.md, where necessary.
  • My changes properly paginate the target service provider's API
  • My changes properly handle rate limiting of the target service provider's
    API
  • My new integration step is instrumented to execute in the correct order
    using dependsOn
  • I have referred to the
    JupiterOne data model
    to ensure that any new entities/relationships, and relevant properties,
    match the recommended model for this class of data
  • I have updated the CHANGELOG.md file to describe my changes
  • When changes include modifications to existing graph data ingestion, I've
    reviewed all existing managed questions referencing the entities,
    relationships, and their property names, to ensure those questions still
    function with my changes.

@RonaldEAM RonaldEAM requested a review from a team as a code owner August 29, 2023 21:51
@socket-security
Copy link

New dependencies detected. Learn more about Socket for GitHub ↗︎

Packages Version New capabilities Transitives Size Publisher
auto 10.46.0 eval, network, shell +117 17 MB alisowski

package.json Outdated
"npm",
{
"setRcToken": false,
"publishFolder": "."

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the publishFolder for this might need to be "./dist" based on the build command above.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You might also need to add a postversion command above to make sure the package.json file gets copied into the ./dist folder after auto finishes versioning it. Example: https://github.com/JupiterOne/graph-cisco-umbrella/blob/546be3e1242aa1b99255d428eb4cb9cffb8f9f02/package.json#L32

@adam-in-ict
Copy link

I think we need to also add .npmrc to the .gitignore file.

@RonaldEAM RonaldEAM merged commit f0ae12d into main Aug 30, 2023
7 checks passed
@RonaldEAM RonaldEAM deleted the INT-9221-add-auto branch August 30, 2023 15:10
@j1-internal-automation
Copy link
Collaborator

🚀 PR was released in v2.0.5 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants