Skip to content

Conversation

@mire3212
Copy link

  • Tweaking a value for the client.py URL, as I think it's causing 404 errors with the new API URL Endpoint.
  • Re-adding the missing warn import statement (not sure if we still need the one line that uses warn(), but it's there none-the-less).
  • Aligning headers value during authentication with what is shown in the docs.
  • Updating test files to use the new API endpoint.
  • Adding config for pytest to help locate the project code.
  • Removing some unused tests.
  • Updating some tests that are referencing old or wrong error codes.

On my local system pytest now passes all tests (though, it might be good to confirm they're all still good).

…to help locate the project code. Removing some unused tests and updating some other tests that are referencing old or wrong error codes
@mire3212 mire3212 requested a review from a team as a code owner July 24, 2024 21:04
@SeaBlooms
Copy link

thanks a lot @mire3212! I'll review these updates shortly

@SeaBlooms SeaBlooms requested a review from a team July 27, 2024 13:21
Copy link

@SeaBlooms SeaBlooms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added some formatting fixes and removed unused imports

@SeaBlooms SeaBlooms merged commit d49d21c into JupiterOne:main Jul 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants