Update client to handle unknown error formats and 401s #4
Conversation
| raise JupiterOneApiError('{}:{}'.format(response.status_code, content.get('error'))) | ||
| try: | ||
| content = json.loads(response._content) | ||
| raise JupiterOneApiError('{}: {}'.format(response.status_code, content.get('error') or 'Unknown Error')) |
There was a problem hiding this comment.
I'm a bit rusty with Python, but I think the or operator doesn't handle nullish coalescing like we'd expect in a TypeScript world. I'm assuming that's why we need the additional try/catch here to catch the ValueError?
We could do some kind of if statement optionally, but I think this solution is fine too.
There was a problem hiding this comment.
I based this logic off of this post:
https://stackoverflow.com/questions/4978738/is-there-a-python-equivalent-of-the-c-sharp-null-coalescing-operator
And I was noticing that content.get was returning None which should be handled by or
There was a problem hiding this comment.
Nice! So is the additional try/catch to handle something else, or more of a belt and suspenders kind of thing?
There was a problem hiding this comment.
Def belt and suspenders. The unknown handler :)
2 participants
Please test this locally since no tests are run on GitHub!!