-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/ H200 siren and C424S2 cameras battery #106
Feature/ H200 siren and C424S2 cameras battery #106
Conversation
Moving it back to draft, for what I see there are some issues with results order that are not trustable, and missing of battery is because of a bug on tapo_control |
Now its ready for review, removed the new methods from getMost because is not going to be possible to call the same method with different params, because of response parsing. And some bugfixes found on tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Looking into .getMost now |
closes #105
PD: formatting with black-formatter as stated in settings made some format changes