Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/ H200 siren and C424S2 cameras battery #106

Conversation

marcosngomezi
Copy link
Contributor

@marcosngomezi marcosngomezi commented Mar 17, 2024

closes #105

  • Adds getHubSirenStatus, getHubSirenConfig getHubSirenTypeList, setHubSirenStatus, setHubSirenConfig and getBatteryStatus

PD: formatting with black-formatter as stated in settings made some format changes

@marcosngomezi marcosngomezi marked this pull request as draft March 17, 2024 05:36
@marcosngomezi marcosngomezi marked this pull request as ready for review March 17, 2024 05:49
@marcosngomezi marcosngomezi marked this pull request as draft April 14, 2024 15:06
@marcosngomezi
Copy link
Contributor Author

marcosngomezi commented Apr 14, 2024

Moving it back to draft, for what I see there are some issues with results order that are not trustable, and missing of battery is because of a bug on tapo_control

@marcosngomezi marcosngomezi marked this pull request as ready for review April 18, 2024 23:17
@marcosngomezi
Copy link
Contributor Author

Now its ready for review, removed the new methods from getMost because is not going to be possible to call the same method with different params, because of response parsing. And some bugfixes found on tests

Copy link
Owner

@JurajNyiri JurajNyiri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@JurajNyiri
Copy link
Owner

Looking into .getMost now

@JurajNyiri JurajNyiri merged commit 33a6828 into JurajNyiri:main Apr 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extra methods for H200 and C420S2 battery cameras
2 participants