Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

!api returns "SteamPassword" in plain text, even if it's set to "null" in the config. file #607

Closed
guihkx opened this issue Aug 5, 2017 · 1 comment
Closed

!api returns "SteamPassword" in plain text, even if it's set to "null" in the config. file #607

guihkx opened this issue Aug 5, 2017 · 1 comment
Labels
✨ Enhancement Issues marked with this label indicate further enhancements to the program, such as new features. 🟢 Low priority Issues marked with this label are actively being worked on if nothing serious is on the list. 🐍 Not a bug Issues marked with this label indicate that given behaviour is intended to happen - not a bug.

Comments

@guihkx
Copy link

guihkx commented Aug 5, 2017 •
edited
Loading

Bug

Description

When ASF is setting up an account for the first time and you have SteamPassword set to null, ASF will ask for the account password. After ASF successfully sets it up, if you issue !api new_bot, ASF will actually give us the password in plain text. This only occurs after setting up an account, if you restart ASF and issue !api new_bot, SteamPassword will be correctly set to null.

Expected behavior

ASF should respect SteamPassword like it's in the configuration file.

Actual behavior

ASF stores the password somewhere and outputs it when you issue !api new_bot.

Steps to reproduce

  1. Set up a new bot with SteamPassword set to null;
  2. Run ASF and wait for it to prompt for your password;
  3. Enter your password;
  4. Do !api new_bot and your password will be displayed in plain text.

ASF version

V3.0.1.2
@guihkx
Copy link
Author

guihkx commented Aug 5, 2017

On a related(ish) note, I think it would be nice if ASF could hide the password when you type it / paste it into the terminal, Like su or sudo do it.

@JustArchi JustArchi added ✨ Enhancement Issues marked with this label indicate further enhancements to the program, such as new features. 🟢 Low priority Issues marked with this label are actively being worked on if nothing serious is on the list. 🐍 Not a bug Issues marked with this label indicate that given behaviour is intended to happen - not a bug. labels Aug 5, 2017
JustArchi added a commit that referenced this issue Aug 9, 2017
@JustArchi
Properly deal with #607, #586
5605e04
@lock lock bot locked as resolved and limited conversation to collaborators Jun 26, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
✨ Enhancement Issues marked with this label indicate further enhancements to the program, such as new features. 🟢 Low priority Issues marked with this label are actively being worked on if nothing serious is on the list. 🐍 Not a bug Issues marked with this label indicate that given behaviour is intended to happen - not a bug.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@guihkx @JustArchi