Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add accordion, update styles for ACRIS links on guide page #44

Merged
merged 3 commits into from
Dec 13, 2024

Conversation

austensen
Copy link
Member

@austensen austensen commented Dec 13, 2024

  • Adds a simple accordion component
  • rework styles for more sensible organization
  • update types for related properties prioritization (will improve sort function later)

also temporarily disabling the loom video, because there's some problem and it is infinitely refreshing

[sc-15954]
[sc-15956]
[sc-15958]

Copy link

netlify bot commented Dec 13, 2024

Deploy Preview for gce-screener ready!

Name Link
🔨 Latest commit dd53077
🔍 Latest deploy log https://app.netlify.com/sites/gce-screener/deploys/675c6907d2d2750008abebd1
😎 Deploy Preview https://deploy-preview-44--gce-screener.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@austensen austensen requested a review from kiwansim December 13, 2024 16:38
Copy link
Member

@kiwansim kiwansim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i'm having cors issues for the preview link, which makes sense since the GCE_ORIGIN defined in tenants2 is only the prod url. should we see if there is a branch deploy url we can use to pass in more than just the prod url for the CORS header?

Screenshot 2024-12-13 at 2 46 29 PM

@austensen
Copy link
Member Author

i'm having cors issues for the preview link, which makes sense since the GCE_ORIGIN defined in tenants2 is only the prod url. should we see if there is a branch deploy url we can use to pass in more than just the prod url for the CORS header?

Screenshot 2024-12-13 at 2 46 29 PM

Oh yeah good point. I'll make a ticket for now and will check with you later about the approach/desired behaviour before starting on that.

@austensen austensen merged commit 5d95156 into main Dec 13, 2024
4 checks passed
@austensen austensen deleted the acris-links branch December 13, 2024 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants